[In-app Purchases] Include purchase result in purchaseProduct API #8133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koke
added
type: task
Generated by 🚫 dangerJS |
toupper
reviewed
Nov 16, 2022
|
|
||
| func purchaseProduct(with id: String, for remoteSiteId: Int64) async throws { | ||
| _ = try await withCheckedThrowingContinuation { continuation in | ||
| func purchaseProduct(with id: String, for remoteSiteId: Int64) async throws -> StoreKit.Product.PurchaseResult { |
Contributor
There was a problem hiding this comment.
It would be great to keep StoreKit references inside the boundaries of the IAP interface if possible, so their clients don't have to even import it. That way we have WPComPlanProduct that acts as a facade of the StoreKit.Product, hiding any details about StoreKit. Can we do the same with StoreKit.Product.PurchaseResult? With a protocol or a typealias?
typealias PurchaseResult = StoreKit.Product.PurchaseResult
Member
Author
There was a problem hiding this comment.
Oh good call, I'll add that
Contributor
|
Thanks for this addition! Now the purchase outcome is more meaningful. |
toupper
approved these changes
Nov 16, 2022
Collaborator
You can test the changes from this Pull Request by:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8130
Description
This updates the
InAppPurchasesForWPComPlansProtocol.purchaseProductso it returns the actualPurchaseResultand the site creation flow is able to differentiate a successful purchase from a pending one or a user cancellation.Testing instructions
Purchase result: userCancelledmessage in the consolePurchase result: success(...message in the consoleRELEASE-NOTES.txtif necessary.